tests: deprecate test/parallel/test-child-process-double-pipe.js

[eljefedelrodeodeljefe]

I am reviewing windows building, testing and other related windows stuff and noticed that this test is quite complex. That might be fair, but it's the only one that requires both sed and grep, which are sort of hard to install dependencies on windows (imo, I am now windows developer though).

In order to ease windows node core hacking, we could deprecate it for some simpler piping test.

Background: I am following https://github.com/nodejs/node/wiki/installation#building-on-windows and am trying to build those dependencies in JS, in order to just npm install -g [...] things. But grep and sed would be too hard I guess.

[Trott]

Removing assumptions of UNIX-like operating systems in tests where possible is probably A Good Thing.

Here's the commit that introduced the test: 07da49b0

You can see the code src/node_child_process.cc that was added in that commit. I would think that any revision or replacement of the test that still exercised/tested that code would be acceptable. Basically, as long as the test fails if that code is missing, then that's probably OK.

[eljefedelrodeodeljefe]

Okay, will have a look and write something up then.

[eljefedelrodeodeljefe]

Having had a look, I believe this particular c++ code moved later to libuv deps/uv/src/unix/core.c:566 and to lib/child_process.js, both with different behaviours, let alone it is js then. In 2011 it got deleted by ryan in 96e423a. I'd tend to remove it altogether or pass some data from one node -e '// some readable stream' to some node -e '// some transform or writable stream'

[eljefedelrodeodeljefe]

...sorry, missed: that is also why I can't break it intentionally, because I can't find the equivalent or whether it is actually breakable anymore.

[eljefedelrodeodeljefe]

I added a PR for deletion of this test. Since it'll likely produce a lot of boilerplate to mimic this tests behaviour without programs like sed and grep. As per argument above I think this test case is anyhow obsolete.

[Trott]

Another possibility, in case things get stalled, would be check common.isWindows and exit with TAP skip output.

(But if the test should legitimately be removed, then let's do that.)

[eljefedelrodeodeljefe]

@Trott didn't know that was possible. I am fine with both. Let's see how it evolves

[eljefedelrodeodeljefe]

@Trott ping. Any more thoughts?

[Trott]

@eljefedelrodeodeljefe Not a whole lot, but I'll put what I have to say over in the PR...

[jasnell]

Closing due to lack of forward progress on this. We can reopen if necessary.