Skip to content

doc: add version meta for SSL_CERT_DIR/FILE #11007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sam-github merged 1 commit into from
Feb 20, 2017
Merged

doc: add version meta for SSL_CERT_DIR/FILE #11007

sam-github merged 1 commit into from
Feb 20, 2017

Conversation

@sam-github
Copy link
Contributor

@sam-github sam-github commented Jan 25, 2017

The metadata markup for when SSL_CERT_DIR and SSL_CERT_FILE added in
33012e9 is missing.

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. dont-land-on-v7.x labels Jan 25, 2017
@sam-github
Copy link
Contributor Author

sam-github commented Jan 25, 2017

Who fills in the FIXME values? Does that happen automatically, or should I fill it in based on when I expect them to be released in 7.x?

evanlucas
evanlucas suggested changes Jan 25, 2017
View reviewed changes
Copy link
Contributor

@evanlucas evanlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These will be updated in the release commit along with the changelog update by the releaser.

doc/api/cli.md Outdated
Copy link
Contributor

@evanlucas evanlucas Jan 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be added: REPLACEME

doc/api/cli.md Outdated
Copy link
Contributor

@evanlucas evanlucas Jan 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be added: REPLACEME

@sam-github sam-github force-pushed the markup-ssl-conf-added-meta branch from 26845fd to 82ad94d Compare January 25, 2017 22:27
@sam-github
Copy link
Contributor Author

sam-github commented Jan 25, 2017

Thanks Evan, fixed the markup, PTAL

@mscdex mscdex added tls Issues and PRs related to the tls subsystem. and removed dont-land-on-v7.x labels Jan 25, 2017
@sam-github
Copy link
Contributor Author

sam-github commented Feb 20, 2017

@evanlucas nudge, PTAL

evanlucas
evanlucas approved these changes Feb 20, 2017
View reviewed changes
Copy link
Contributor

@evanlucas evanlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry I had forgotten about this one :]

Thanks!

@sam-github
Copy link
Contributor Author

sam-github commented Feb 20, 2017

I forgot, too, thanks for the review.

@sam-github sam-github force-pushed the markup-ssl-conf-added-meta branch from 82ad94d to ad2ad1f Compare February 20, 2017 15:31
@sam-github
doc: add version meta for SSL_CERT_DIR/FILE
d2de2ad 
The metadata markup for when SSL_CERT_DIR and SSL_CERT_FILE added in
33012e9 is missing.

PR-URL: nodejs#11007
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@sam-github sam-github force-pushed the markup-ssl-conf-added-meta branch from ad2ad1f to d2de2ad Compare February 20, 2017 15:31
@sam-github sam-github merged commit d2de2ad into nodejs:master Feb 20, 2017
@sam-github sam-github deleted the markup-ssl-conf-added-meta branch February 20, 2017 15:33
@sam-github
Copy link
Contributor Author

sam-github commented Feb 20, 2017

@italoacasas low risk doc-only fixup for 7.x if there is still time

@italoacasas
Copy link

italoacasas commented Feb 20, 2017

@sam-github I already freeze the proposal since the release is tomorrow. This should be part of 7.7.0 (Feb 28).

@sam-github
Copy link
Contributor Author

sam-github commented Feb 20, 2017

@italoacasas no problem, thanks for looking

addaleax pushed a commit that referenced this pull request Feb 22, 2017
@sam-github @addaleax
doc: add version meta for SSL_CERT_DIR/FILE
20d86db 
The metadata markup for when SSL_CERT_DIR and SSL_CERT_FILE added in
33012e9 is missing.

PR-URL: #11007
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@italoacasas italoacasas mentioned this pull request Feb 25, 2017
Merged
@jasnell
Copy link
Member

jasnell commented Mar 7, 2017

this would need a backport PR to land in v4 or v6

@sam-github
Copy link
Contributor Author

sam-github commented Mar 10, 2017

I don't think it needs backporting, it will likely land clean if the PR it fixes up lands: #8334 (which does need backporting)

@sam-github sam-github mentioned this pull request Mar 10, 2017
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

+1 more reviewer

@evanlucas evanlucas evanlucas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sam-github @italoacasas @jasnell @evanlucas @mscdex @nodejs-github-bot