doc, inspector: note that the host is optional #12149
Merged
+7
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
mscdex
added
doc
eugeneo
approved these changes
Mar 31, 2017
richardlau
approved these changes
Mar 31, 2017
targos
approved these changes
Apr 2, 2017
jasnell
approved these changes
Apr 3, 2017
Document that `node --inspect=${port}` is also a viable option.
PR-URL: nodejs#12149
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Apr 10, 2017
Document that `node --inspect=${port}` is also a viable option.
PR-URL: nodejs#12149
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Contributor
|
is this true for the v6 inspector? |
Member
Author
|
Yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document that
node --inspect=${port}is also a viable option.Checklist
tests and/or benchmarks are includedThere are already tests for this behaviour: sequential/test-debugger-debug-brk.js inspector/test-inspector-ip-detection.jsAffected core subsystem(s)
doc
[commit guidelines]: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-guidelines
EDIT: CI: https://ci.nodejs.org/job/node-test-commit/8834/