[v8.x backport] build: allow enabling the --trace-maps flag in V8 #14344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be useful for tracing map creation. PR-URL: nodejs#14018 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com>
nodejs-github-bot
added
build
bnoordhuis
approved these changes
Jul 18, 2017
refack
approved these changes
Jul 18, 2017
Member
|
I don’t think running CI for this makes sense, but Thanks, landed in |
addaleax
pushed a commit
that referenced
this pull request
Jul 18, 2017
This can be useful for tracing map creation. Backport-PR-URL: #14344 Backport-Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Backport-Reviewed-By: Refael Ackermann <refack@gmail.com> PR-URL: #14018 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com>
Fishrock123
pushed a commit
that referenced
this pull request
Jul 19, 2017
This can be useful for tracing map creation. Backport-PR-URL: #14344 Backport-Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Backport-Reviewed-By: Refael Ackermann <refack@gmail.com> PR-URL: #14018 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #14018 to v8.x
This can be useful for tracing map creation.
PR-URL: #14018
Reviewed-By: Ben Noordhuis info@bnoordhuis.nl
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: Anna Henningsen anna@addaleax.net
Reviewed-By: Refael Ackermann refack@gmail.com
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)