Skip to content

Conversation

@ronag
Copy link
Member

@ronag ronag commented Sep 8, 2017

Set aborted property on incoming requests.

@nodejs-github-bot nodejs-github-bot added the http Issues or PRs related to the http subsystem. label Sep 8, 2017
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use Date.now() to make it consistent with http.ClientRequest?

@lpinca
Copy link
Member

lpinca commented Sep 9, 2017

A test should be added or an existing one modified in order to cover this addition.

@ronag
Copy link
Member Author

ronag commented Sep 10, 2017

@lpinca: Uses Date.now().

@jasnell jasnell added the semver-minor PRs that contain new features and should be released in the next minor version. label Sep 14, 2017
@jasnell
Copy link
Member

jasnell commented Sep 14, 2017

Ping @nodejs/http

@jasnell
Copy link
Member

jasnell commented Sep 14, 2017

This would also need docs added, in addition to a test.

Also, it could use a bit more text justifying why

@BridgeAR
Copy link
Member

Ping @ronag

@ronag ronag mentioned this pull request Sep 21, 2017
@BridgeAR
Copy link
Member

Neither am I sure if this is something we really want to have nor is this a complete. @ronag are you planning on pursuing this further?

@ronag
Copy link
Member Author

ronag commented Sep 27, 2017

@BridgeAR nope :)

@BridgeAR
Copy link
Member

Thanks! I am closing this in that case.

@BridgeAR BridgeAR closed this Sep 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

http Issues or PRs related to the http subsystem. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants