Skip to content

Conversation

@kreig303
Copy link

@kreig303 kreig303 commented Sep 18, 2017

Checklist

Ref: #11273

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

errors, crypto, doc

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. errors Issues and PRs related to JavaScript errors originated in Node.js core. labels Sep 18, 2017
@kreig303 kreig303 changed the title errors crypto.ks : Migrate errors to internal/errors.js errors crypto.js : Migrate errors to internal/errors.js Sep 18, 2017
@kreig303 kreig303 changed the title errors crypto.js : Migrate errors to internal/errors.js errors crypto : Migrate errors to internal/errors.js Sep 18, 2017
@kreig303 kreig303 changed the title errors crypto : Migrate errors to internal/errors.js errors crypto : migrate errors to internal/errors.js Sep 18, 2017
@jasnell
Copy link
Member

jasnell commented Sep 18, 2017

@kreig303 .. thank you very much for this work. It is greatly appreciated. One thing, however, much of this, I believe, is already covered by #15231, which should land at some point this morning. Once that lands, perhaps rebase this and take another look at what parts are remaining?

@kreig303
Copy link
Author

kreig303 commented Sep 18, 2017

@jasnell i had to laugh when i saw your reply. my own work told me that crypto.js needed refactoring so #15231 makes sense. i'll look to see what i can salvage but i'm guessing this PR is toast!

On the bright side having done this once it's obviously easy to redirect the knowledge at other internal/errors.js targets.

@kreig303 kreig303 closed this Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

crypto Issues and PRs related to the crypto subsystem. errors Issues and PRs related to JavaScript errors originated in Node.js core.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants