src: fixup node_platform blocking task drain #15639
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs#15428 was supposed to account for upcoming changes in V8 upstream, but while addressing review comments a bug was introduced; `DrainBackgroundTasks()` should always at least perform one blocking drain on the background task queue. Ref: nodejs#15428 Ref: f27b5e4
nodejs-github-bot
added
the
c++
Member
Author
|
(If you’re wondering why there’s no test here: Because right now everything still works. 😄 It might be nice for us to get a basic WASM test into our test suite, but that seems like a perfect slightly-more-advanced task for Code & Learn in Vancouver.) |
cjihrig
approved these changes
Sep 27, 2017
2 tasks
|
thank you |
Closed
jasnell
approved these changes
Sep 28, 2017
Member
Author
|
CI: https://ci.nodejs.org/job/node-test-commit/12673/ (edit: should be fine 👍) |
addaleax
added
backport-requested-v8.x
lib / src
bnoordhuis
approved these changes
Sep 29, 2017
Member
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
LGTM but does it matter that this changes the order of foreground vs. background tasks? (I'm guessing no.)
There's a lot of red in the CI. I think it's unrelated but CI again just in case: https://ci.nodejs.org/job/node-test-pull-request/10340/
Member
Author
I agree, that shouldn’t matter – I don’t think V8 can expect any particular timing/ordering of background tasks beyond what is implied by causal relations |
Member
|
Landed in dcd890a |
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Oct 1, 2017
nodejs#15428 was supposed to account for upcoming changes in V8 upstream, but while addressing review comments a bug was introduced; `DrainBackgroundTasks()` should always at least perform one blocking drain on the background task queue. PR-URL: nodejs#15639 Refs: nodejs#15428 Refs: f27b5e4 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
addaleax
added a commit
to addaleax/ayo
that referenced
this pull request
Oct 4, 2017
nodejs/node#15428 was supposed to account for upcoming changes in V8 upstream, but while addressing review comments a bug was introduced; `DrainBackgroundTasks()` should always at least perform one blocking drain on the background task queue. PR-URL: nodejs/node#15639 Refs: nodejs/node#15428 Refs: f27b5e4bdaafc73a830a0451ee3c641b8bcd08fe Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Contributor
addaleax
added a commit
to addaleax/node
that referenced
this pull request
Oct 14, 2017
nodejs#15428 was supposed to account for upcoming changes in V8 upstream, but while addressing review comments a bug was introduced; `DrainBackgroundTasks()` should always at least perform one blocking drain on the background task queue. PR-URL: nodejs#15639 Refs: nodejs#15428 Refs: f27b5e4 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
#15428 was supposed to account for upcoming changes in V8 upstream, but while addressing review comments a bug was introduced; `DrainBackgroundTasks()` should always at least perform one blocking drain on the background task queue. PR-URL: #15639 Refs: #15428 Refs: f27b5e4 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
#15428 was supposed to account for upcoming changes in V8 upstream, but while addressing review comments a bug was introduced; `DrainBackgroundTasks()` should always at least perform one blocking drain on the background task queue. PR-URL: #15639 Refs: #15428 Refs: f27b5e4 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Contributor
|
Should this be backported to v6.x? |
Contributor
|
ping @addaleax |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#15428 was supposed to account for upcoming changes in V8 upstream, but while addressing review comments a bug was introduced;
DrainBackgroundTasks()should always at least perform one blocking drain on the background task queue.Ref: #15428
Ref: f27b5e4
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src/node_platform
@hashseed @nodejs/v8