test: replaced common.fixturesDir usage in http2-respond-file-push test #15823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmg
approved these changes
Oct 6, 2017
Contributor
rmg
left a comment
rmg
left a comment
There was a problem hiding this comment.
Looks great! Thanks for the contribution!
Trott
added
the
code-and-learn
benjamingr
approved these changes
Oct 7, 2017
richardlau
approved these changes
Oct 7, 2017
cjihrig
approved these changes
Oct 7, 2017
tniessen
approved these changes
Oct 7, 2017
lpinca
approved these changes
Oct 9, 2017
danbev
pushed a commit
to danbev/node
that referenced
this pull request
Oct 9, 2017
This commit replaces the usage of common.fixturesDir with fixtures.path. PR-URL: nodejs#15823 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Contributor
|
Landed in 56c0e7d. Thanks! |
MylesBorins
pushed a commit
that referenced
this pull request
Oct 11, 2017
This commit replaces the usage of common.fixturesDir with fixtures.path. PR-URL: #15823 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 12, 2017
This commit replaces the usage of common.fixturesDir with fixtures.path. PR-URL: nodejs/node#15823 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the usage of
common.fixturesDirwithfixtures.path. I didn't bother usingfixtures.readFileSyncsince the file name was needed forfs.statSyncandfs.openSync.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes