Skip to content

Conversation

@kkwoker
Copy link
Contributor

@kkwoker kkwoker commented Oct 6, 2017

This commit also puts the first two tests in scope.
expected_result was being overwritten in the second test before the first test passes, creating a race condition.

Checklist
  • [x ] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • [ x] commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added dont-land-on-v4.x node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. labels Oct 6, 2017
@joyeecheung
Copy link
Member

@kkwoker
Copy link
Contributor Author

kkwoker commented Oct 6, 2017

I duplicated this PR in #16037, and have a better solution for cleaning up the assertion values

@kkwoker kkwoker closed this Oct 6, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants