Fix dgram.md typos #16183
Closed
Fix dgram.md typos #16183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
socket.getRecvBufferSize() and socket.getSendBufferSize() do not take any parameter
nodejs-github-bot
added
dgram
jasnell
approved these changes
Oct 13, 2017
cjihrig
approved these changes
Oct 14, 2017
hiroppy
approved these changes
Oct 14, 2017
joyeecheung
reviewed
Oct 14, 2017
Member
joyeecheung
left a comment
joyeecheung
left a comment
There was a problem hiding this comment.
I don't think this needs 48 hours to land
joyeecheung
pushed a commit
that referenced
this pull request
Oct 14, 2017
socket.getRecvBufferSize() and socket.getSendBufferSize() do not take any parameter PR-URL: #16183 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Member
|
Landed in 34c47ed with commit messages fixed. Thank you for the contribution and next time, be sure to check out our commit message guidelines. |
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 15, 2017
socket.getRecvBufferSize() and socket.getSendBufferSize() do not take any parameter PR-URL: nodejs/node#16183 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
socket.getRecvBufferSize() and socket.getSendBufferSize() do not take any parameter PR-URL: #16183 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
socket.getRecvBufferSize() and socket.getSendBufferSize() do not take any parameter
Checklist
Affected core subsystem(s)
doc