test: http2 util passing array in te header

[trivikr]

This adds a test case in which array with two values is passed to param value in isIllegalConnectionSpecificHeader:

node/lib/internal/http2/util.js

Line 363 in 212de3c

const val = Array.isArray(value) ? value.join(', ') : value;

Refs: #14985

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

Affected core subsystem(s)

test, http2

[mcollina]

LGTM

[mcollina]

CI: https://ci.nodejs.org/job/node-test-pull-request/10774/

[apapirovski]

Just a note for future reference if someone wants to take it on, the pathway this is testing could actually be refactored a bit:

node/lib/internal/http2/util.js

Lines 363 to 364 in ff747e3

	const val = Array.isArray(value) ? value.join(', ') : value;
	return val !== 'trailers';

value will never be an array with length < 2 because of

node/lib/internal/http2/util.js

Lines 405 to 416 in ff747e3

	const isArray = Array.isArray(value);
	if (isArray) {
	switch (value.length) {
	case 0:
	continue;
	case 1:
	value = String(value[0]);
	break;
	default:
	if (kSingleValueHeaders.has(key))
	return new errors.Error('ERR_HTTP2_HEADER_SINGLE_VALUE', key);
	}

so it could just be rewritten as:

return value !== 'trailers';

[trivikr]

Thanks @apapirovski, I've updated the commit to add toString() to cover both cases as follows:

return value.toString() !== 'trailers';

Commit is at trivikr@596df98
However, I'm not able to see it in this PR https://github.com/nodejs/node/pull/16246/files
Could this be because CI is running on older commit?

[apapirovski]

toString() isn't necessary here (and is bad for perf). If an array slips through then it won't match anyway (because it has at least two items in it). Should just be value !== 'trailers'.

[trivikr]

removed toString() in the updated commit

[apapirovski]

LGTM 👍

[apapirovski]

CI: https://ci.nodejs.org/job/node-test-pull-request/10825/

[apapirovski]

Landed in 1fd662c