Skip to content

Conversation

@saghul
Copy link
Member

@saghul saghul commented May 6, 2015

@saghul
Copy link
Member Author

saghul commented May 6, 2015

@cjihrig
Copy link
Contributor

cjihrig commented May 6, 2015

For bookkeeping purposes, this should close #1397.

@Fishrock123
Copy link
Contributor

#862 should also be closable by this.. still looking through the list for others.

@ChALkeR
Copy link
Member

ChALkeR commented May 6, 2015

#1621

@Fishrock123
Copy link
Contributor

#1512 also I think.

Those four issues seem to be the ones this fixes.

@silverwind silverwind mentioned this pull request May 6, 2015
bnoordhuis pushed a commit that referenced this pull request May 6, 2015
Fixes: #1397
Fixes: #1512
Fixes: #1621
Fixes: #862
PR-URL: #1646
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@bnoordhuis
Copy link
Member

LGTM and the CI is happy. Landed in 04cc03b, thanks Saúl.

@bnoordhuis bnoordhuis closed this May 6, 2015
@rvagg rvagg mentioned this pull request May 7, 2015
@rvagg
Copy link
Member

rvagg commented May 7, 2015

I might need some help crafting a Notable Changes entry about this, I wasn't aware that we had so much resting on this, can someone in here take a stab at a summary of what this buys us? Also, great work @saghul, @bnoordhuis and other libuv folk!

@bnoordhuis
Copy link
Member

@rvagg

Maybe @indutny can comment on #1512. I kind of zoned out after the first few messages.

Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request May 19, 2015
Fixes: nodejs#1397
Fixes: nodejs#1512
Fixes: nodejs#1621
Fixes: nodejs#862
PR-URL: nodejs#1646
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants