Skip to content

repl: show proxies as Proxy objects #16485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bnoordhuis wants to merge 2 commits into from
Closed

repl: show proxies as Proxy objects #16485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4da7a85
repl: show proxies as Proxy objects
bnoordhuis Oct 25, 2017
15b5ff0
fixup! remove extra blank line
bnoordhuis Oct 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions lib/repl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,9 @@ function hasOwnProperty(obj, prop) {

// Can overridden with custom print functions, such as `probe` or `eyes.js`.
// This is the default "writer" value if none is passed in the REPL options.
exports.writer = util.inspect;
const writer = exports.writer = (obj) => util.inspect(obj, writer.options);
writer.options =
Object.assign(util.inspect.defaultOptions, { showProxy: true });

exports._builtinLibs = internalModule.builtinLibs;

Expand Down Expand Up @@ -370,11 +372,10 @@ function REPLServer(prompt,
}
self.useColors = !!options.useColors;

if (self.useColors && self.writer === util.inspect) {
if (self.useColors && self.writer === writer) {
// Turn on ANSI coloring.
self.writer = function(obj, showHidden, depth) {
return util.inspect(obj, showHidden, depth, true);
};
self.writer = (obj) => util.inspect(obj, self.writer.options);
self.writer.options = Object.assign(writer.options, { colors: true });
}

function filterInternalStackFrames(error, structuredStack) {
Expand Down
11 changes: 11 additions & 0 deletions test/parallel/test-repl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,6 +412,17 @@ function error_test() {
expect: `${prompt_multiline}${prompt_multiline}undefined\n${prompt_unix}`
},

// https://github.com/nodejs/node/issues/16483
{
client: client_unix, send: 'new Proxy({x:42}, {get(){throw null}});',
expect: `Proxy [ { x: 42 }, { get: [Function: get] } ]\n${prompt_unix}`
},
{
client: client_unix,
send: 'repl.writer.options.showProxy = false, new Proxy({x:42}, {});',
expect: `{ x: 42 }\n${prompt_unix}`
},

// Newline within template string maintains whitespace.
{ client: client_unix, send: '`foo \n`',
expect: `${prompt_multiline}'foo \\n'\n${prompt_unix}` },
Expand Down