Skip to content

build: use higher version c++ #16501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
refack wants to merge 3 commits into from
Closed

build: use higher version c++ #16501

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
90f055f
build: use higher version c++
refack Oct 25, 2017
076af6b
[sqwsh] only for C++ files
refack Oct 25, 2017
198ae69
[try] macOS plays hard to get
refack Oct 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@
'component%': 'static_library', # NB. these names match with what V8 expects
'msvs_multi_core_compile': '0', # we do enable multicore compiles, but not using the V8 way
'python%': 'python',

'gas_version%': 0,
'llvm_version%': 0,
Copy link
Contributor

@seishun seishun Oct 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this?

Copy link
Member

@targos targos Oct 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a variable set in the configure script when clang is detected.

Copy link
Contributor

@seishun seishun Oct 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused. The configure script wasn't modified in this PR. How come these two lines weren't necessary before?

Copy link
Contributor Author

@refack refack Oct 26, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to check llvm_version version (without first doing "feature detection"), we need these vars with default value (90f055f).

Copy link
Contributor Author

@refack refack Oct 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P.S. It not necessary in the current changeset, so I could move this to a new PR


'node_shared%': 'false',
'force_dynamic_crt%': 0,
'node_use_v8_platform%': 'true',
Expand Down Expand Up @@ -198,6 +200,7 @@
# simply not feasible to squelch all warnings, never mind that the
# libraries in deps/ are not under our control.
'cflags!': ['-Werror'],
'cflags_cc': [ '-std=gnu++11' ],
'msvs_settings': {
'VCCLCompilerTool': {
'StringPooling': 'true', # pool string literals
Expand All @@ -211,6 +214,9 @@
# and their sheer number drowns out other, more legitimate warnings.
'DisableSpecificWarnings': ['4267'],
'WarnAsError': 'false',
'AdditionalOptions': [
'/std:c++14'
Copy link
Contributor

@seishun seishun Oct 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary, both VS2015 and VS2015 default to /std:c++14.

Copy link
Contributor Author

@refack refack Oct 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather have this (1) for being explicit (2) for future proofing, in case the default changes to C++17 or higher

],
},
'VCLibrarianTool': {
},
Expand Down Expand Up @@ -293,7 +299,7 @@
}],
[ 'OS in "linux freebsd openbsd solaris android aix"', {
'cflags': [ '-Wall', '-Wextra', '-Wno-unused-parameter', ],
'cflags_cc': [ '-fno-rtti', '-fno-exceptions', '-std=gnu++0x' ],
'cflags_cc': [ '-fno-rtti', '-fno-exceptions' ],
'ldflags': [ '-rdynamic' ],
'target_conditions': [
# The 1990s toolchain on SmartOS can't handle thin archives.
Expand Down Expand Up @@ -409,7 +415,7 @@
['clang==1', {
'xcode_settings': {
'GCC_VERSION': 'com.apple.compilers.llvm.clang.1_0',
'CLANG_CXX_LANGUAGE_STANDARD': 'gnu++0x', # -std=gnu++0x
'CLANG_CXX_LANGUAGE_STANDARD': 'c++14', # -std=c++14
'CLANG_CXX_LIBRARY': 'libc++',
},
}],
Expand All @@ -431,7 +437,7 @@
'ldflags': [
'-Wl,--export-dynamic',
],
}]
}],
],
}
}