src: remove throws in set/getHiddenValue #16544
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
jasnell
force-pushed
the
migrate-util-hidden-value
branch
from
9e54ea8 to
c322f6b
Compare
jasnell
added
the
semver-major
jasnell
commented
Oct 27, 2017
lib/repl.js
Outdated
Member
Author
There was a problem hiding this comment.
to protect against the odd random non-object being emitted on the domain error event. If e is not an object, it will trigger the CHECK
lpinca
reviewed
Oct 27, 2017
test/parallel/test-util-internal.js
Outdated
Member
There was a problem hiding this comment.
Nit: not sure why this uses deepStrictEqual. I think it should be strictEqual.
lpinca
approved these changes
Oct 27, 2017
apapirovski
approved these changes
Oct 27, 2017
Member
Author
|
ping @nodejs/tsc |
These are internal only utility functions, CHECK instead of throw
jasnell
force-pushed
the
migrate-util-hidden-value
branch
from
c322f6b to
7925adc
Compare
joyeecheung
approved these changes
Oct 30, 2017
Member
Author
Member
Author
|
Failures in CI are entirely unrelated. |
jasnell
added a commit
that referenced
this pull request
Nov 2, 2017
These are internal only utility functions, CHECK instead of throw PR-URL: #16544 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Member
Author
|
Landed in 3d20190 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setHiddenValue()andgetHiddenValue()are internal only utility functions, CHECK instead of throwChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
util