doc: deprecate top-level this being bound to module.exports #16878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Not really sure what this is looking to accomplish. Can you provide some additional context? |
Member
|
@jasnell There was some discussion about this in the linked issue |
addaleax
approved these changes
Nov 8, 2017
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
LGTM, let’s just hope nobody thinks it’s a good idea to add a runtime deprecation
Member
|
@addaleax ... yes, but the commit message has none of that context and that context is not clear in the doc update. |
jasnell
reviewed
Nov 8, 2017
doc/api/deprecations.md
Outdated
| necessary in user space. | ||
| <a id="DEP0083"></a> | ||
| ### DEP0083: Top-level `this` bound to `module.exports` |
Member
There was a problem hiding this comment.
These should be DEP00XX until it lands.
cjihrig
approved these changes
Nov 8, 2017
lpinca
approved these changes
Nov 14, 2017
Member
|
Ping @Hackzzila can you rebase this against master? Thanks! |
Member
|
ping @Hackzzila again |
BridgeAR
added
the
author ready
Member
|
I am going to land this tomorrow. |
jasnell
added
the
semver-major
Member
|
Landed in 300f5ce |
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Feb 1, 2018
PR-URL: nodejs#16878 Fixes: nodejs#9623 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
PR-URL: nodejs#16878 Fixes: nodejs#9623 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
tniessen
added
deprecations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added using the top-level
thisas an alternative tomodule.exportsto the list of deprecated APIs.Fixes: #9623
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc