src: remove process._debugPause() #17060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
bnoordhuis
added
the
semver-major
cjihrig
approved these changes
Nov 15, 2017
addaleax
approved these changes
Nov 15, 2017
refack
approved these changes
Nov 15, 2017
TimothyGu
approved these changes
Nov 15, 2017
targos
approved these changes
Nov 15, 2017
evanlucas
approved these changes
Nov 16, 2017
This method is undocumented and depends on a V8 API that is slated for removal. The inspector and node-inspect don't use it and I could find no third-party code that depends on it. Remove it. PR-URL: nodejs#17060 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com>
bnoordhuis
force-pushed
the
rm-process-debug-pause
branch
from
7f2bef7 to
804eb3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method is undocumented and depends on a V8 API that is slated for
removal. The inspector and node-inspect don't use it and I could find
no third-party code that depends on it. Remove it.
CI: https://ci.nodejs.org/job/node-test-pull-request/11463/