[v8.x backport] test,doc: do not indicate that non-functions "return" values #17768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Backport of #17267 |
2 tasks
gibfahn
approved these changes
Dec 20, 2017
Member
|
@Trott looks like this somehow already has conflicts. |
gibfahn
force-pushed
the
v8.x-staging
branch
from
f34ae26 to
d8d1995
Compare
Trott
force-pushed
the
backport-17267
branch
from
dd97ac6 to
e6882a9
Compare
Update documentation for test `common` module so that properties that are not functions do not specify a return type and functions that do return values specify the type. PR-URL: nodejs#17267 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Trott
force-pushed
the
backport-17267
branch
from
e6882a9 to
675b214
Compare
Member
Author
|
@gibfahn rebased and force-pushed CI: https://ci.nodejs.org/job/node-test-pull-request-lite/34/ |
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
Update documentation for test `common` module so that properties that are not functions do not specify a return type and functions that do return values specify the type. PR-URL: #17267 Backport-PR-URL: #17768 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Member
|
Landed in 563f1f6 |
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
Update documentation for test `common` module so that properties that are not functions do not specify a return type and functions that do return values specify the type. PR-URL: #17267 Backport-PR-URL: #17768 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update documentation for test
commonmodule so that properties thatare not functions do not specify a return type and functions that do
return values specify the type.
PR-URL: #17267
Reviewed-By: Vse Mozhet Byt vsemozhetbyt@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Gibson Fahnestock gibfahn@gmail.com
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test doc