doc: fix typo in esm.md #18142
Closed
doc: fix typo in esm.md #18142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change `run time` to `runtime` for both correctness and consistency with every other instance of the expression in the docs.
lpinca
approved these changes
Jan 14, 2018
danbev
approved these changes
Jan 14, 2018
TimothyGu
approved these changes
Jan 14, 2018
fhinkel
approved these changes
Jan 14, 2018
Member
Author
jasnell
approved these changes
Jan 14, 2018
Member
|
sorry about this 😄 |
cjihrig
approved these changes
Jan 14, 2018
tniessen
approved these changes
Jan 15, 2018
XadillaX
approved these changes
Jan 16, 2018
maclover7
approved these changes
Jan 18, 2018
maclover7
added
the
author ready
Member
Author
|
Landed in 359a232 |
Trott
added a commit
that referenced
this pull request
Jan 18, 2018
Change `run time` to `runtime` for both correctness and consistency with every other instance of the expression in the docs. PR-URL: #18142 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Jon Moss <me@jonathanmoss.me>
addaleax
removed
the
author ready
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
Change `run time` to `runtime` for both correctness and consistency with every other instance of the expression in the docs. PR-URL: nodejs#18142 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Jon Moss <me@jonathanmoss.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
run timetoruntimefor both correctness and consistency withevery other instance of the expression in the docs.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc