Skip to content

test: fix flaky interval test #18161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
apapirovski wants to merge 1 commit into from
Closed

test: fix flaky interval test #18161

apapirovski wants to merge 1 commit into from

Conversation

@apapirovski
Copy link
Contributor

@apapirovski apapirovski commented Jan 15, 2018 •
edited
Loading

Ok, this version is almost good enough to be in parallel — only fails 1 time with -j 96 --repeat 960. Should definitely be good enough for sequential. Still fails 100 out of 100 on older node versions.

Fixes: #18160

/cc @Trott

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 15, 2018
@apapirovski
Copy link
Contributor Author

apapirovski commented Jan 15, 2018 •
edited
Loading

CI:
https://ci.nodejs.org/job/node-test-pull-request/12538/
https://ci.nodejs.org/job/node-test-pull-request/12544/
Stress test CI: https://ci.nodejs.org/job/node-stress-single-test/1687/

Trott
Trott approved these changes Jan 15, 2018
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@apapirovski apapirovski added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 15, 2018
mhdawson
mhdawson approved these changes Jan 15, 2018
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott
Copy link
Member

Trott commented Jan 16, 2018

+1 to fast-tracking

@joyeecheung joyeecheung added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 17, 2018
@joyeecheung
Copy link
Member

joyeecheung commented Jan 17, 2018

Landed in b88da49, thanks!

joyeecheung pushed a commit that referenced this pull request Jan 17, 2018
@apapirovski @joyeecheung
test: fix flaky interval test
b88da49 
PR-URL: #18161
Fixes: #18160
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 18, 2018
@apapirovski apapirovski deleted the fix-test-interval-cb-duration branch January 18, 2018 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees

No one assigned

Labels

fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix flaky sequential/test-timers-set-interval-excludes-callback-duration

8 participants

@apapirovski @Trott @joyeecheung @lpinca @mhdawson @MylesBorins @addaleax @nodejs-github-bot