Skip to content

src: clean up argument assertions in node_file.cc #18192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
joyeecheung wants to merge 1 commit into from
Closed

src: clean up argument assertions in node_file.cc #18192

joyeecheung wants to merge 1 commit into from

Conversation

@joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Jan 16, 2018

  • Cache args.Length()
  • Use value.As<T>() to cast the arguments
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

fs

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. labels Jan 16, 2018
bnoordhuis
bnoordhuis approved these changes Jan 17, 2018
View reviewed changes
src/node_file.cc Outdated
Copy link
Member

@bnoordhuis bnoordhuis Jan 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const int argc = ... if you're caching it. .Length() is really just an inexpensive pointer load though.

@joyeecheung
src: clean up argument assertions in node_file.cc
95d9201 
- Cache `args.Length()`
- Use `value.As<T>()` to cast the arguments
@joyeecheung
Copy link
Member Author

joyeecheung commented Jan 20, 2018

Rebased and updated with @bnoordhuis's suggestion.

CI: https://ci.nodejs.org/job/node-test-pull-request/12631/

@joyeecheung
Copy link
Member Author

joyeecheung commented Jan 20, 2018 •
edited
Loading

Only one unrelated CI failure. Landed in e1c29f2, thanks!

joyeecheung added a commit that referenced this pull request Jan 20, 2018
@joyeecheung
src: clean up argument assertions in node_file.cc
e1c29f2 
- Cache `args.Length()`
- Use `value.As<T>()` to cast the arguments

PR-URL: #18192
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins
Copy link
Contributor

MylesBorins commented Feb 20, 2018

This does not land cleanly on v9.x, would someone be willing to do a backport?

@joyeecheung
Copy link
Member Author

joyeecheung commented Feb 21, 2018

This is cleaning up the code mostly came from semver-major changes, so does not make too much sense to backport.

MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@joyeecheung @MayaLekova
src: clean up argument assertions in node_file.cc
79dbb18 
- Cache `args.Length()`
- Use `value.As<T>()` to cast the arguments

PR-URL: nodejs#18192
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@joyeecheung @MylesBorins @bnoordhuis @jasnell @cjihrig @nodejs-github-bot