test: improve fs error message test #18277
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reuse error validators for sync and async tests - Validate properties of the errors
Member
Author
targos
approved these changes
Jan 21, 2018
| assert.strictEqual(nonexistentFile, err.path); | ||
| // Could be resolved to an absolute path | ||
| assert.ok(err.dest.endsWith('foo'), | ||
| `expect ${err.dest} to ends with 'foo'`); |
| assert.strictEqual(nonexistentFile, err.path); | ||
| // Could be resolved to an absolute path | ||
| assert.ok(err.dest.endsWith('foo'), | ||
| `expect ${err.dest} to ends with 'foo'`); |
| } catch (err) { | ||
| errors.push('opens'); | ||
| assert.ok(err.message.includes(fn)); | ||
| // rmdir |
| } catch (err) { | ||
| errors.push('readdir'); | ||
| assert.ok(err.message.includes(fn)); | ||
| // read |
Member
Author
|
@targos Thanks for the review. Updated.
|
joyeecheung
force-pushed
the
fs-err-msg
branch
from
e127886 to
15061d2
Compare
cjihrig
approved these changes
Jan 22, 2018
jasnell
approved these changes
Jan 22, 2018
Member
Author
|
Only one unrelated failure in the last CI. Fired another one just in case: https://ci.nodejs.org/job/node-test-pull-request/12664/ |
joyeecheung
added
the
author ready
Member
Author
|
Landed in 63f78f5, thanks! |
joyeecheung
added a commit
that referenced
this pull request
Jan 23, 2018
- Reuse error validators for sync and async tests - Validate properties of the errors PR-URL: #18277 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
joyeecheung
removed
the
author ready
Contributor
|
Should this be backported to |
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
- Reuse error validators for sync and async tests - Validate properties of the errors PR-URL: nodejs#18277 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for more fs error migrations..
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test, fs