Skip to content

timers: fix enroll deprecation wording #18704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
apapirovski wants to merge 1 commit into from
Closed

timers: fix enroll deprecation wording #18704

apapirovski wants to merge 1 commit into from

Conversation

@apapirovski
Copy link
Contributor

@apapirovski apapirovski commented Feb 10, 2018

Fixes the suggested function to be setTimeout not clearTimeout, to match the docs.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

timers

@apapirovski apapirovski added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 10, 2018
@nodejs-github-bot nodejs-github-bot added the timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. label Feb 10, 2018
@apapirovski
Copy link
Contributor Author

apapirovski commented Feb 10, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/167/

@apapirovski apapirovski added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 10, 2018
Fishrock123
Fishrock123 approved these changes Feb 11, 2018
View reviewed changes
Copy link
Contributor

@Fishrock123 Fishrock123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙊

@apapirovski
Copy link
Contributor Author

apapirovski commented Feb 11, 2018

Landed in 2aa3e3b

@apapirovski apapirovski deleted the fix-timers-enroll-deprecation branch February 11, 2018 15:34
apapirovski added a commit that referenced this pull request Feb 11, 2018
@apapirovski
timers: fix enroll deprecation wording
2aa3e3b 
PR-URL: #18704
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins
Copy link
Contributor

MylesBorins commented Feb 21, 2018

Does not land cleanly on v9.x, setting as don't land

MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@apapirovski @MayaLekova
timers: fix enroll deprecation wording
7756296 
PR-URL: nodejs#18704
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

+4 more reviewers

@ChALkeR ChALkeR ChALkeR approved these changes

@Fishrock123 Fishrock123 Fishrock123 approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@maclover7 maclover7 maclover7 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@apapirovski @MylesBorins @ChALkeR @Fishrock123 @lpinca @TimothyGu @cjihrig @maclover7 @nodejs-github-bot