Skip to content

fs: move fs.promises API to fs/promises #18777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
targos wants to merge 3 commits into from
Closed

fs: move fs.promises API to fs/promises #18777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fab7afe
fs: move utility functions to internal/fs
targos Feb 14, 2018
5df426f
fs: move fs.promises API to fs/promises
targos Feb 14, 2018
75d27f1
fixup: remove extra space
targos Feb 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions benchmark/fs/bench-stat-promise.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict';

const common = require('../common');
const fs = require('fs');
const fsPromises = require('fs/promises');

const bench = common.createBenchmark(main, {
n: [20e4],
Expand All @@ -10,11 +10,11 @@ const bench = common.createBenchmark(main, {

async function run(n, statType) {
const arg = statType === 'fstat' ?
await fs.promises.open(__filename, 'r') : __filename;
await fsPromises.open(__filename, 'r') : __filename;
let remaining = n;
bench.start();
while (remaining-- > 0)
await fs.promises[statType](arg);
await fsPromises[statType](arg);
bench.end(n);

if (typeof arg.close === 'function')
Expand Down
Loading