Revert "test: add test cases for fsPromises" #19101
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c05c73a. The commit breaks Raspberry Pi CI. Refs: nodejs#19064 (comment)
Trott
added
flaky-test
Member
Author
4 tasks
watilde
approved these changes
Mar 3, 2018
cjihrig
approved these changes
Mar 3, 2018
Member
Author
|
(Raspberry Pi CI is green with this revert.) |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Mar 3, 2018
This reverts commit c05c73a. The commit breaks Raspberry Pi CI. PR-URL: nodejs#19101 Ref: nodejs#19064 (comment) Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Member
Author
|
Landed in 4bfc03b |
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
This reverts commit c05c73a. The commit breaks Raspberry Pi CI. PR-URL: nodejs#19101 Ref: nodejs#19064 (comment) Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c05c73a.
The commit breaks Raspberry Pi CI.
Refs: #19064 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test