fs: simplify FSReqBase slightly #19174
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the `data_` member of `FSReqBase` by a boolean flag, because the pointer that `data()` returns is already available through the `buffer_` member, and set the default size for not requiring an extra allocation to a more reasonable value, as the input is usually something like a file path.
nodejs-github-bot
added
c++
Member
Author
|
CI: https://ci.nodejs.org/job/node-test-commit/16716/ (edit: 👍 ) |
jasnell
approved these changes
Mar 6, 2018
cjihrig
approved these changes
Mar 6, 2018
joyeecheung
approved these changes
Mar 7, 2018
addaleax
added
the
author ready
Member
|
Landed in f96bd54 🎉 |
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 11, 2018
Replace the `data_` member of `FSReqBase` by a boolean flag, because the pointer that `data()` returns is already available through the `buffer_` member, and set the default size for not requiring an extra allocation to a more reasonable value, as the input is usually something like a file path. PR-URL: nodejs#19174 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
Replace the `data_` member of `FSReqBase` by a boolean flag, because the pointer that `data()` returns is already available through the `buffer_` member, and set the default size for not requiring an extra allocation to a more reasonable value, as the input is usually something like a file path. PR-URL: nodejs#19174 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the
data_member ofFSReqBaseby a boolean flag, becausethe pointer that
data()returns is already available through thebuffer_member, and set the default size for not requiring anextra allocation to a more reasonable value, as the input is
usually something like a file path.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes