Skip to content

Conversation

@danbev
Copy link
Contributor

@danbev danbev commented Mar 9, 2018

PR-URL: #18893
Reviewed-By: Michaël Zasso targos@protonmail.com
Reviewed-By: Minwoo Jung minwoo@nodesource.com
Reviewed-By: Yuta Hiroto hello@about-hiroppy.com
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: Ruben Bridgewater ruben@bridgewater.de
Reviewed-By: Gibson Fahnestock gibfahn@gmail.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

PR-URL: nodejs#18893
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. v9.x labels Mar 9, 2018
@danbev
Copy link
Contributor Author

danbev commented Mar 9, 2018

@danbev
Copy link
Contributor Author

danbev commented Mar 9, 2018

node-test-commit failure looks unrelated

console output:

FATAL: java.io.IOException: Unexpected EOF while receiving the data from the channel. FIFO buffer has been already closed
org.jenkinsci.remoting.nio.FifoBuffer$CloseCause: Buffer close has been requested
	at org.jenkinsci.remoting.nio.FifoBuffer.close(FifoBuffer.java:426)
	at org.jenkinsci.remoting.nio.NioChannelHub$MonoNioTransport.closeR(NioChannelHub.java:338)
	at org.jenkinsci.remoting.nio.NioChannelHub.run(NioChannelHub.java:571)
Caused: java.io.IOException: Unexpected EOF while receiving the data from the channel. FIFO buffer has been already closed
	at org.jenkinsci.remoting.nio.NioChannelHub$3.run(NioChannelHub.java:629)
Also:   hudson.remoting.Channel$CallSiteStackTrace: Remote call to Channel to /72.2.114.47
		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1693)
		at hudson.remoting.Request.call(Request.java:192)
		at hudson.remoting.Channel.call(Channel.java:907)
		at hudson.Launcher$RemoteLauncher.kill(Launcher.java:1079)
		at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:510)
		at hudson.model.Run.execute(Run.java:1724)
		at hudson.matrix.MatrixRun.run(MatrixRun.java:146)
		at hudson.model.ResourceController.execute(ResourceController.java:97)
		at hudson.model.Executor.run(Executor.java:429)
Caused: hudson.remoting.RequestAbortedException
	at hudson.remoting.Request.abort(Request.java:329)
	at hudson.remoting.Channel.terminate(Channel.java:992)
	at org.jenkinsci.remoting.nio.NioChannelHub$3.run(NioChannelHub.java:628)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at hudson.remoting.SingleLaneExecutorService$1.run(SingleLaneExecutorService.java:112)
	at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)
[Current build status] check if current [FAILURE] is worse or equals then [UNSTABLE] and better or equals then [SUCCESS]
Run condition [Current build status] preventing perform for step [[]]
ERROR: Step ?Publish TAP Results? failed: no workspace for node-test-commit-smartos/nodes=smartos14-64 #15945
Checking ^not ok
ERROR: Build step failed with exception
java.lang.NullPointerException
Build step 'Jenkins Text Finder' marked build as failure
Notifying upstream projects of job completion
Finished: FAILURE

MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
Backport-PR-URL: #19253
PR-URL: #18893
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@MylesBorins
Copy link
Contributor

landed in 1ba1861

@danbev danbev deleted the backport-18893-to-v9.x branch March 27, 2018 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants