url: replace "magic" numbers by constants #19300
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
dont-land-on-v4.x
whatwg-url
jasnell
approved these changes
Mar 12, 2018
lib/internal/url.js
Outdated
Member
There was a problem hiding this comment.
is the trailing comma required?
Contributor
Author
There was a problem hiding this comment.
@gireeshpunathil no, it's not required, but allowed. I can delete it (should I?), but I think it's a better way to work with multiline "lists"
Member
There was a problem hiding this comment.
I prefer the trailing comma but others don't, I don't think we have consensus, so I'd say do whatever you prefer @daynin .
watilde
approved these changes
Mar 13, 2018
gibfahn
approved these changes
Mar 15, 2018
Contributor
Author
|
@nodejs/collaborators Hello! Run CI for this PR, please |
Member
Member
|
CI is failing for |
daynin
force-pushed
the
url-replace-numbers
branch
from
1c01efd to
622505d
Compare
Contributor
Author
|
I resolved a conflict |
Member
Member
|
Landed in 354849e. |
lpinca
pushed a commit
that referenced
this pull request
Apr 5, 2018
PR-URL: #19300 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 6, 2018
PR-URL: #19300 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes