Skip to content

util: add boxed BigInt formatting to util.inspect #19341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
targos wants to merge 1 commit into from
Closed

util: add boxed BigInt formatting to util.inspect #19341

targos wants to merge 1 commit into from
+9 −0

Conversation

@targos
Copy link
Member

@targos targos commented Mar 14, 2018

Before:

> Object(7n)
BigInt {}

After:

> Object(7n)
[BigInt: 7n]
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@targos
util: add boxed BigInt formatting to util.inspect
4fb0af1 
Before:

> Object(7n)
BigInt {}

After:

> Object(7n)
[BigInt: 7n]
@nodejs-github-bot nodejs-github-bot added the util Issues and PRs related to the built-in util module. label Mar 14, 2018
@BridgeAR
Copy link
Member

BridgeAR commented Mar 14, 2018

CI https://ci.nodejs.org/job/node-test-pull-request/13670/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 14, 2018
@targos
Copy link
Member Author

targos commented Mar 17, 2018

Landed in 893432a

@targos targos closed this Mar 17, 2018
@targos targos deleted the inspect-boxed-bigint branch March 17, 2018 10:39
targos added a commit that referenced this pull request Mar 17, 2018
@targos
util: add boxed BigInt formatting to util.inspect
893432a 
Before:

> Object(7n)
BigInt {}

After:

> Object(7n)
[BigInt: 7n]

PR-URL: #19341
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
@tniessen tniessen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

+1 more reviewer

@devsnek devsnek devsnek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@targos @BridgeAR @jasnell @cjihrig @devsnek @tniessen @nodejs-github-bot