Skip to content

test: move ESM fixtures to fixtures dir #19409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
targos wants to merge 1 commit into from
Closed

test: move ESM fixtures to fixtures dir #19409

targos wants to merge 1 commit into from

Conversation

@targos
Copy link
Member

@targos targos commented Mar 17, 2018

Also consistently import the common module where possible.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 17, 2018
@targos targos added the esm Issues and PRs related to the ECMAScript Modules implementation. label Mar 17, 2018
guybedford
guybedford approved these changes Mar 17, 2018
View reviewed changes
Copy link
Contributor

@guybedford guybedford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for cleaning these up!

richardlau
richardlau reviewed Mar 17, 2018
View reviewed changes
test/parallel/test-module-main-extension-lookup.js Outdated
Copy link
Member

@richardlau richardlau Mar 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this use the common.fixtures module?

Copy link
Member Author

@targos targos Mar 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks

@targos
test: move ESM fixtures to fixtures dir
ecc6965 
Also consistently import the `common` module where possible.
@targos targos force-pushed the test-esm-fixtures branch from 8a599b3 to ecc6965 Compare March 21, 2018 07:45
@targos
Copy link
Member Author

targos commented Mar 21, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/13798/

@targos
Copy link
Member Author

targos commented Mar 21, 2018

Landed in fddcd62

@targos targos closed this Mar 21, 2018
@targos targos deleted the test-esm-fixtures branch March 21, 2018 19:12
targos added a commit that referenced this pull request Mar 21, 2018
@targos
test: move ESM fixtures to fixtures dir
fddcd62 
Also consistently import the `common` module where possible.

PR-URL: #19409
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@guybedford guybedford guybedford approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

+2 more reviewers

@XadillaX XadillaX XadillaX approved these changes

@devsnek devsnek devsnek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

esm Issues and PRs related to the ECMAScript Modules implementation. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@targos @jasnell @guybedford @cjihrig @XadillaX @richardlau @devsnek @nodejs-github-bot