Skip to content

test: update assert messages to show expected and actual values #19420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
domahony wants to merge 4 commits into from
Closed

test: update assert messages to show expected and actual values #19420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
386b4db
test: update assert messages to show expected and actual values
domahony Mar 17, 2018
9c470d7
test: update test to use regularly formatted test data
domahony Mar 17, 2018
47e6411
test: update test to use regularly formatted test data
domahony Mar 17, 2018
cfb0cc3
test: update test to use a test file from test/fixtures
domahony Mar 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions test/fixtures/readfile_pipe_test.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
xxxx xxxx xxxx xxxx
xxxx xxxx xxxx xxxx
xxxx xxxx xxxx xxxx
xxxx xxxx xxxx xxxx
xxxx xxxx xxxx xxxx
19 changes: 14 additions & 5 deletions test/parallel/test-fs-readfile-pipe.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@ if (common.isWindows || common.isAIX)
const assert = require('assert');
const fs = require('fs');

const dataExpected = fs.readFileSync(__filename, 'utf8');

if (process.argv[2] === 'child') {
fs.readFile('/dev/stdin', function(er, data) {
assert.ifError(er);
Expand All @@ -40,13 +38,24 @@ if (process.argv[2] === 'child') {
return;
}

const fixtures = require('../common/fixtures');

const filename = fixtures.path('readfile_pipe_test.txt');
const dataExpected = fs.readFileSync(filename).toString();

const exec = require('child_process').exec;
const f = JSON.stringify(__filename);
const node = JSON.stringify(process.execPath);
const cmd = `cat ${f} | ${node} ${f} child`;
const cmd = `cat ${filename} | ${node} ${f} child`;
exec(cmd, function(err, stdout, stderr) {
assert.ifError(err);
assert.strictEqual(stdout, dataExpected, 'it reads the file and outputs it');
assert.strictEqual(stderr, '', 'it does not write to stderr');
assert.strictEqual(
stdout,
dataExpected,
`expected to read: '${dataExpected}' but got: '${stdout}'`);
assert.strictEqual(
stderr,
'',
`expected not to read anything from stderr but got: '${stderr}'`);
console.log('ok');
});