Skip to content

Conversation

@rvagg
Copy link
Member

@rvagg rvagg commented Jun 11, 2015

No description provided.

@mscdex mscdex added the doc Issues and PRs related to the documentations. label Jun 11, 2015
@bnoordhuis
Copy link
Member

LGTM but can I suggest s/added/add/? Most commit logs are in the present tense.

@thefourtheye
Copy link
Contributor

Should we mention a note about not disclosing to public till the vulnerability is addressed properly?

@rvagg
Copy link
Member Author

rvagg commented Jun 14, 2015

thanks for the reminder @bnoordhuis, I keep forgetting

@thefourtheye check out the latest, I've added a note about that

@jbergstroem
Copy link
Member

LGTM. Good to get security going.

@thefourtheye
Copy link
Contributor

LGTM 👍

rvagg added a commit that referenced this pull request Jun 19, 2015
PR-URL: #1948
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@Fishrock123
Copy link
Contributor

Landed in 8ac5081!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants