Skip to content

Conversation

@hiroppy
Copy link
Member

@hiroppy hiroppy commented Mar 25, 2018

Related #19563 (comment).

/cc @jasnell

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

CI: https://ci.nodejs.org/job/node-test-pull-request-lite/322/

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. perf_hooks Issues and PRs related to the implementation of the Performance Timing API. labels Mar 25, 2018
@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 25, 2018
@trivikr
Copy link
Member

trivikr commented Mar 25, 2018

@trivikr
Copy link
Member

trivikr commented Mar 25, 2018

Landed in 9125479

@trivikr trivikr closed this Mar 25, 2018
trivikr pushed a commit that referenced this pull request Mar 25, 2018
add `http2` to performanceEntry.entryType in perf_hooks

PR-URL: #19584
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@hiroppy hiroppy deleted the feature/update-perf_hooks-doc branch March 26, 2018 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. perf_hooks Issues and PRs related to the implementation of the Performance Timing API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants