src: rename fs_req_wrap -> FSReqWrapSync #19614
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit renames fs_req_wrap to FSReqWrapSync to make it consistent with most of the other classes in the code base.
nodejs-github-bot
added
c++
Contributor
Author
joyeecheung
approved these changes
Mar 26, 2018
Member
joyeecheung
left a comment
joyeecheung
left a comment
There was a problem hiding this comment.
Thanks, I was thinking about renaming this but struggled with coming up with a good name...FSReqWrapSync seems perfect
| } else { // access(path, mode, undefined, ctx) | ||
| CHECK_EQ(argc, 4); | ||
| fs_req_wrap req_wrap; | ||
| FSReqWrapSync req_wrap; |
Member
There was a problem hiding this comment.
In retrospect variables like this can be renamed req_wrap_sync and those FSReqBase* can be renamed req_wrap_async to avoid the confusion of name shadowing..not really what this PR needs to deal with though.
Contributor
Author
There was a problem hiding this comment.
I noticed that too and think we should change that. I'll follow up this is in a different PR. Thanks!
trivikr
approved these changes
Mar 26, 2018
thefourtheye
approved these changes
Mar 26, 2018
addaleax
approved these changes
Mar 27, 2018
2 tasks
jasnell
approved these changes
Mar 28, 2018
Member
Contributor
Author
node-test-commit failure looks unrelatedBuilding addon /home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcle-ubuntu1404/test/addons/stringbytes-external-exceed-max/
gyp '/home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcle-ubuntu1404/test/addons-napi/test_symbol/build/config.gypi',
make[2]: write error
gyp info spawn argsmake[1]: *** [doc-only] Error 1
'-I',
gypmake[1]: *** Waiting for unfinished jobs.... |
Contributor
Author
|
Landed in 376f949. |
danbev
added a commit
that referenced
this pull request
Mar 29, 2018
This commit renames fs_req_wrap to FSReqWrapSync to make it consistent with most of the other classes in the code base. PR-URL: #19614 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
danbev
added a commit
to danbev/node
that referenced
this pull request
Apr 3, 2018
This commit renames the req_wrap variable to use an -async/-sync suffix to avoid cases where the variables were being shadowed. Refs: nodejs#19614
alexeykuzmin
added a commit
to electron/node
that referenced
this pull request
Apr 27, 2018
src: rename fs_req_wrap -> FSReqWrapSync nodejs/node#19614
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit renames fs_req_wrap to FSReqWrapSync to make it consistent
with most of the other classes in the code base.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes