Skip to content

build: allow vcbuild to merely build addon tests #19637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gabrielschulhof wants to merge 1 commit into from
Closed

build: allow vcbuild to merely build addon tests #19637

gabrielschulhof wants to merge 1 commit into from

Conversation

@gabrielschulhof
Copy link
Contributor

@gabrielschulhof gabrielschulhof commented Mar 27, 2018

Checklist

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. labels Mar 27, 2018
bnoordhuis
bnoordhuis reviewed Mar 27, 2018
View reviewed changes
vcbuild.bat Outdated
Copy link
Member

@bnoordhuis bnoordhuis Mar 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set set

Copy link
Contributor Author

@gabrielschulhof gabrielschulhof Mar 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D'oh!

@gabrielschulhof
Copy link
Contributor Author

gabrielschulhof commented Mar 27, 2018

@bnoordhuis I removed the extra set.

@richardlau
Copy link
Member

richardlau commented Mar 27, 2018

Context for anyone else reviewing: nodejs/build#1097

@gabrielschulhof
Copy link
Contributor Author

gabrielschulhof commented Apr 3, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/14023/

@gabrielschulhof
Copy link
Contributor Author

gabrielschulhof commented Apr 4, 2018

I believe these test failures are unrelated.

gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 4, 2018
build: allow vcbuild to merely build addon tests
a972ed4 
RE: nodejs/build#1097
PR-URL: nodejs#19637
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@gabrielschulhof gabrielschulhof deleted the vcbuild-build-addons branch April 4, 2018 17:14
@gabrielschulhof
Copy link
Contributor Author

gabrielschulhof commented Apr 4, 2018

Landed in a972ed4.

@gabrielschulhof gabrielschulhof restored the vcbuild-build-addons branch April 4, 2018 17:21
@gabrielschulhof
Copy link
Contributor Author

gabrielschulhof commented Apr 4, 2018

Re-opening in case this needs to remain on the radar for 6.x and 8.x.

targos pushed a commit that referenced this pull request Apr 6, 2018
@targos
build: allow vcbuild to merely build addon tests
adf890a 
RE: nodejs/build#1097
PR-URL: #19637
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@gabrielschulhof gabrielschulhof deleted the vcbuild-build-addons branch April 9, 2018 01:32
@richardlau richardlau mentioned this pull request May 25, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis left review comments

@jasnell jasnell jasnell approved these changes

@richardlau richardlau richardlau approved these changes

+1 more reviewer

@gibfahn gibfahn gibfahn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@gabrielschulhof @richardlau @bnoordhuis @jasnell @gibfahn @BethGriggs @nodejs-github-bot