tty: improve tty color detection #19730
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds attributions for the getColorDepth function as it got inspired by https://github.com/chalk/supports-color and more sources.
This adds support for a couple more terminals.
nodejs-github-bot
added
build
Member
Author
addaleax
approved these changes
Apr 1, 2018
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
Seems fine to me, if @sindresorhus is okay with it too.
Also, fyi: http://no-color.org/
Member
Author
|
@addaleax I actually know that site, I just did not come up with the idea to use the information properly. So thanks a lot 👍 |
richardlau
approved these changes
Apr 1, 2018
BridgeAR
added
the
author ready
jasnell
approved these changes
Apr 3, 2018
trivikr
approved these changes
Apr 3, 2018
Member
Author
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Apr 4, 2018
This adds attributions for the getColorDepth function as it got inspired by https://github.com/chalk/supports-color and more sources. PR-URL: nodejs#19730 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Apr 4, 2018
This adds support for a couple more terminals. PR-URL: nodejs#19730 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
removed
the
author ready
targos
pushed a commit
that referenced
this pull request
Apr 6, 2018
This adds attributions for the getColorDepth function as it got inspired by https://github.com/chalk/supports-color and more sources. PR-URL: #19730 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 6, 2018
This adds support for a couple more terminals. PR-URL: #19730 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the
getColorDepthfunction to the newinternal/ttyfile. This is important to properly give attributions to @sindresorhus.I also improved the detection by adding new values that should be checked. I am currently playing around with
ncurseshas_colors function. It does seem to work fine, I am just not sure where I should expose the function and how this should work on e.g. Windows. Somewhat similar:tput colors. Adding that would allow to detect simple color support. A couple of the terminals that support colors actually support more colors than currently returned, but I did not yet find a good way to always detect the version (as I have to install the terminal etc...). If anyone has a idea how to detect color support without checking environment variables: please let me know.printfandreadcan be used in combination, I am just not sure how to make use of that information for Node.js.This definitely needs a backport to 9.x.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes