test: re-naming the test cases appropriately to be more descriptive #19765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivikr
approved these changes
Apr 3, 2018
tniessen
approved these changes
Apr 3, 2018
ryzokuken
approved these changes
Apr 3, 2018
cjihrig
approved these changes
Apr 3, 2018
jasnell
approved these changes
Apr 3, 2018
Member
Member
|
@rajdhandus can you please resolve the conflicts? Thanks. |
Contributor
Author
|
Sure.. |
Member
|
@rajdhandus Please don't use merge commits to resolve conflicts but rebase your changes on top of our |
test-process-geteuid-getegid.js will be renamed to test-process-euid-egid.js test-process-setuid-setgid.js will be renamed to test-process-uid-gid.js Fixes: nodejs#19592
Contributor
Author
|
sorry... working on revising the PR now.. |
rajdhandus
force-pushed
the
rename-tests-branch
branch
from
88cd357 to
5a76d41
Compare
Member
Member
|
Landed in fde93f8, thank you! 🎉 |
tniessen
pushed a commit
that referenced
this pull request
Apr 7, 2018
test-process-geteuid-getegid.js is renamed to test-process-euid-egid.js. test-process-setuid-setgid.js is renamed to test-process-uid-gid.js. PR-URL: #19765 Fixes: #19592 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 12, 2018
test-process-geteuid-getegid.js is renamed to test-process-euid-egid.js. test-process-setuid-setgid.js is renamed to test-process-uid-gid.js. PR-URL: #19765 Fixes: #19592 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test cases will be re-named to be more appropriate.
test-process-geteuid-getegid.js will be renamed to
test-process-euid-egid.js
test-process-setuid-setgid.js will be renamed to
test-process-uid-gid.js
Fixes: #19592
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes