doc: update AUTHORS list #19768
Closed
doc: update AUTHORS list #19768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
meta
BridgeAR
reviewed
Apr 3, 2018
Member
BridgeAR
left a comment
BridgeAR
left a comment
There was a problem hiding this comment.
For some entries the corresponding name of the person can be found in their github profile. Should we always use that name?
AUTHORS
Outdated
| Ujjwal Sharma <usharma1998@gmail.com> | ||
| Wei-Wei Wu <wuxx1045@umn.edu> | ||
| punteek <prateek1@ucla.edu> | ||
| Tobias Nießen <tniessen@users.noreply.github.com> |
Member
There was a problem hiding this comment.
This entry should be reflected in the mailmap.
AUTHORS
Outdated
| Tobias Nießen <tniessen@users.noreply.github.com> | ||
| Ken Lin <ken23421@gmail.com> | ||
| Piotr Grzesik <pj.grzesik@gmail.com> | ||
| feugy <damien.feugas@gmail.com> |
Member
There was a problem hiding this comment.
The name is "Damien Feugas" and should be reflected as such (he has a middle name but I guess that is not important?).
Member
Author
|
Updated with names found in github profiles |
jasnell
reviewed
Apr 3, 2018
| Abe Fettig <abefettig@gmail.com> <abe@fettig.net> | ||
| Akito Ito <akito0107@gmail.com> <akito_ito@r.recruit.co.jp> | ||
| Alejandro Estrada <estrada9166@gmail.com> | ||
| Alejandro Estrada <estrada9166@gmail.com> <estrada9166@hotmail.com> |
Member
Author
There was a problem hiding this comment.
It has to be like that AFAICT. First entry for the name (it is lowercase in the commit log). Second entry for the email alias.
Closed
Member
Author
targos
added a commit
to targos/node
that referenced
this pull request
Apr 6, 2018
PR-URL: nodejs#19768 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Member
Author
|
Landed in dca09a7 |
targos
added a commit
that referenced
this pull request
Apr 6, 2018
PR-URL: #19768 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.