errors: fix typo in internal/errors.js #19800
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corrects "eqaul" to "equal" in the description for the ERR_NAPI_INVALID_DATAVIEW_ARGS error message
nodejs-github-bot
added
the
errors
cjihrig
approved these changes
Apr 4, 2018
BridgeAR
approved these changes
Apr 4, 2018
targos
approved these changes
Apr 4, 2018
tniessen
approved these changes
Apr 4, 2018
Contributor
Contributor
|
Not sure if the full CI is needed. It seems no tests check this message literally: https://github.com/nodejs/node/search?utf8=%E2%9C%93&q=eqaul&type= |
vsemozhetbyt
added
the
author ready
jasnell
approved these changes
Apr 4, 2018
trivikr
approved these changes
Apr 5, 2018
Member
|
Landed in f8b3774. |
lpinca
pushed a commit
that referenced
this pull request
Apr 6, 2018
Corrects "eqaul" to "equal" in the description for the ERR_NAPI_INVALID_DATAVIEW_ARGS error message. PR-URL: #19800 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 12, 2018
Corrects "eqaul" to "equal" in the description for the ERR_NAPI_INVALID_DATAVIEW_ARGS error message. PR-URL: #19800 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
corrects "eqaul" to "equal" in the description
for the ERR_NAPI_INVALID_DATAVIEW_ARGS error message
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes