errors: alter ERR_HTTP2_INVALID_PSEUDOHEADER #19808
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
errors
jasnell
approved these changes
Apr 4, 2018
BridgeAR
added
the
semver-major
changes the base instance for ERR_HTTP2_INVALID_PSEUDOHEADER from Error to TypeError as a more accurate representation of the error.
BridgeAR
approved these changes
Apr 4, 2018
Member
trivikr
approved these changes
Apr 5, 2018
BridgeAR
added
the
author ready
Member
|
Landed in add1c02 |
mcollina
removed
the
author ready
mcollina
pushed a commit
that referenced
this pull request
Apr 9, 2018
changes the base instance for ERR_HTTP2_INVALID_PSEUDOHEADER from Error to TypeError as a more accurate representation of the error. PR-URL: #19808 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Member
|
Since http2 is still experimental, I think this can be semver-patch? |
Member
|
@targos yes! |
BridgeAR
removed
the
semver-major
targos
pushed a commit
that referenced
this pull request
Apr 12, 2018
changes the base instance for ERR_HTTP2_INVALID_PSEUDOHEADER from Error to TypeError as a more accurate representation of the error. PR-URL: #19808 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes the base instance for ERR_HTTP2_INVALID_PSEUDOHEADER
from Error to TypeError as a more accurate representation
of the error.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes