Skip to content

doc: fix some links #19860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vsemozhetbyt wants to merge 1 commit into from
Closed

doc: fix some links #19860

vsemozhetbyt wants to merge 1 commit into from

Conversation

@vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt commented Apr 7, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 7, 2018
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 7, 2018
@vsemozhetbyt
Copy link
Contributor Author

vsemozhetbyt commented Apr 7, 2018

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/445/

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 7, 2018
@vsemozhetbyt
Copy link
Contributor Author

vsemozhetbyt commented Apr 7, 2018

Landed in 0ac6ced

@vsemozhetbyt vsemozhetbyt deleted the doc-fix-links-2018-04-07 branch April 7, 2018 09:45
vsemozhetbyt added a commit that referenced this pull request Apr 7, 2018
@vsemozhetbyt
doc: fix some links
0ac6ced 
PR-URL: #19860
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Apr 12, 2018
@vsemozhetbyt @targos
doc: fix some links
5a5a18c 
PR-URL: #19860
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@trivikr trivikr trivikr approved these changes

+1 more reviewer

@starkwang starkwang starkwang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@vsemozhetbyt @lpinca @cjihrig @starkwang @trivikr @nodejs-github-bot