test: verify multiple init via well-known symbol #19875
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-`require()` the addon after clearing its cache to ensure that it is re-initialized via the well-known symbol.
nodejs-github-bot
added
addons
3 tasks
Trott
approved these changes
Apr 8, 2018
cjihrig
approved these changes
Apr 8, 2018
BridgeAR
approved these changes
Apr 8, 2018
Member
BridgeAR
added
fast-track
Contributor
Author
|
Landed in 244af7a. |
gabrielschulhof
pushed a commit
that referenced
this pull request
Apr 9, 2018
Re-`require()` the addon after clearing its cache to ensure that it is re-initialized via the well-known symbol. PR-URL: #19875 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
pushed a commit
that referenced
this pull request
Apr 12, 2018
Re-`require()` the addon after clearing its cache to ensure that it is re-initialized via the well-known symbol. PR-URL: #19875 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-
require()the addon after clearing its cache to ensure that it isre-initialized via the well-known symbol.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes