assert: provide info about actual error #19884
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case a error is caught in `assert.doesNotThrow` or `assert.doesNotReject` it will now also indicate what the real error message was.
nodejs-github-bot
added
the
assert
BridgeAR
commented
Apr 9, 2018
| } | ||
| ); | ||
|
|
||
| common.expectsError( |
BridgeAR
added
the
semver-major
lpinca
reviewed
Apr 9, 2018
test/parallel/test-assert.js
Outdated
| type: assert.AssertionError, | ||
| code: 'ERR_ASSERTION', | ||
| message: 'Got unwanted exception.\nundefined' | ||
| message: 'Got unwanted exception.\nActual message: undefined' |
Member
There was a problem hiding this comment.
This still uses common.expectsError(), is this wanted?
Contributor
There was a problem hiding this comment.
Exactly. This call seems similar to https://github.com/nodejs/node/pull/19884/files#diff-81c8c31c5728ec9ed47700e55d9ceebfL127.
Can't this be changed to assert.throws(...) as well?
jasnell
approved these changes
Apr 9, 2018
Member
Author
Member
Author
|
Fixed failing test and I added quotes around the actual message to highlight what is part of it. New CI https://ci.nodejs.org/job/node-test-pull-request/14164/ |
ryzokuken
approved these changes
Apr 10, 2018
lpinca
approved these changes
Apr 10, 2018
Member
Author
|
Landed in 2bee799 |
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Apr 12, 2018
In case a error is caught in `assert.doesNotThrow` or `assert.doesNotReject` it will now also indicate what the real error message was. PR-URL: nodejs#19884 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Apr 16, 2018
In case a error is caught in `assert.doesNotThrow` or `assert.doesNotReject` it will now also indicate what the real error message was. PR-URL: #19884 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case a error is caught in
assert.doesNotThroworassert.doesNotRejectit will now also indicate what the realerror message was.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes