Skip to content

src: add node_internal.h includes for arraysize #19916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
danbev wants to merge 1 commit into from
Closed

src: add node_internal.h includes for arraysize #19916

danbev wants to merge 1 commit into from

Conversation

@danbev
Copy link
Contributor

@danbev danbev commented Apr 10, 2018

This commit adds includes for node_internal.h in source files that use
arraysize but don't include this header. The motivation for this is to
make refactoring easier (and is the reason I noticed this).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@danbev
src: add node_internal.h includes for arraysize
fc69609 
This commit adds includes for node_internal.h in source files that use
arraysize but don't include this header. The motivation for this is to
make refactoring easier (and is the reason I noticed this).
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Apr 10, 2018
@danbev
Copy link
Contributor Author

danbev commented Apr 10, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/14177/

@BridgeAR BridgeAR added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Apr 11, 2018
@danbev
Copy link
Contributor Author

danbev commented Apr 12, 2018

node-test-commit (1) failure looks unrelated

console output:

09:36:47 not ok 807 parallel/test-http-readable-data-event
09:36:47   ---
09:36:47   duration_ms: 0.410
09:36:47   severity: fail
09:36:47   stack: |-
09:36:47     assert.js:79
09:36:47       throw new AssertionError(obj);
09:36:47       ^
09:36:47     
09:36:47     AssertionError [ERR_ASSERTION]: 'Hello World!Hello again later!' strictEqual 'Hello World!'
09:36:47         at IncomingMessage.res.on.common.mustCall (/home/iojs/build/workspace/node-test-commit-linux/nodes/debian8-x86/test/parallel/test-http-readable-data-event.js:43:14)
09:36:47         at IncomingMessage.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux/nodes/debian8-x86/test/common/index.js:467:15)
09:36:47         at IncomingMessage.emit (events.js:182:13)
09:36:47         at IncomingMessage.Readable.read (_stream_readable.js:489:10)
09:36:47         at IncomingMessage.res.on.common.mustCall (/home/iojs/build/workspace/node-test-commit-linux/nodes/debian8-x86/test/parallel/test-http-readable-data-event.js:36:20)
09:36:47         at IncomingMessage.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux/nodes/debian8-x86/test/common/index.js:467:15)
09:36:47         at IncomingMessage.emit (events.js:182:13)
09:36:47         at emitReadable_ (_stream_readable.js:537:12)
09:36:47         at process._tickCallback (internal/process/next_tick.js:174:19)
09:36:47   ...
09:36:47 ok 808 parallel/test-http-remove-header-stays-removed
09:36:47   ---
node-test-commit (2) failure looks unrelated

console output:

09:25:12    Started by user Daniel Bevenius
09:25:12 [EnvInject] - Loading node environment variables.
09:25:12 Building remotely on test-digitalocean-ubuntu1604-x86-1 (ubuntu1604-32) in workspace /home/iojs/build/workspace/node-test-commit-linux/nodes/ubuntu1604-32
09:25:12 Also:   hudson.remoting.Channel$CallSiteStackTrace: Remote call to Channel to /159.203.77.233
09:25:12 		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1737)
09:25:12 		at hudson.remoting.UserResponse.retrieve(UserRequest.java:313)
09:25:12 		at hudson.remoting.Channel.call(Channel.java:952)
09:25:12 		at hudson.FilePath.act(FilePath.java:998)
09:25:12 		at hudson.FilePath.act(FilePath.java:987)
09:25:12 		at org.jenkinsci.plugins.gitclient.Git.getClient(Git.java:137)
09:25:12 		at hudson.plugins.git.GitSCM.createClient(GitSCM.java:795)
09:25:12 		at hudson.plugins.git.GitSCM.createClient(GitSCM.java:786)
09:25:12 		at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1154)
09:25:12 		at hudson.scm.SCM.checkout(SCM.java:504)
09:25:12 		at hudson.model.AbstractProject.checkout(AbstractProject.java:1203)
09:25:12 		at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
09:25:12 		at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
09:25:12 		at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
09:25:12 		at hudson.model.Run.execute(Run.java:1727)
09:25:12 		at hudson.matrix.MatrixRun.run(MatrixRun.java:146)
09:25:12 		at hudson.model.ResourceController.execute(ResourceController.java:97)
09:25:12 		at hudson.model.Executor.run(Executor.java:429)
09:25:12 java.lang.NoClassDefFoundError: Could not initialize class com.sun.proxy.$Proxy11
09:25:12 	at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
09:25:12 	at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
09:25:12 	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
09:25:12 	at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
09:25:12 	at java.lang.reflect.Proxy.newProxyInstance(Proxy.java:739)
09:25:12 	at hudson.remoting.RemoteInvocationHandler.wrap(RemoteInvocationHandler.java:143)
09:25:12 	at hudson.remoting.Channel.export(Channel.java:621)
09:25:12 	at hudson.remoting.Channel.export(Channel.java:590)
09:25:12 	at org.jenkinsci.plugins.gitclient.LegacyCompatibleGitAPIImpl.writeReplace(LegacyCompatibleGitAPIImpl.java:198)
09:25:12 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
09:25:12 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
09:25:12 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
09:25:12 	at java.lang.reflect.Method.invoke(Method.java:498)
09:25:12 	at java.io.ObjectStreamClass.invokeWriteReplace(ObjectStreamClass.java:1218)
09:25:12 	at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1136)
09:25:12 	at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:348)
09:25:12 	at hudson.remoting.UserRequest._serialize(UserRequest.java:157)
09:25:12 	at hudson.remoting.UserRequest.serialize(UserRequest.java:166)
09:25:12 	at hudson.remoting.UserRequest.perform(UserRequest.java:128)
09:25:12 	at hudson.remoting.UserRequest.perform(UserRequest.java:48)
09:25:12 	at hudson.remoting.Request$2.run(Request.java:326)
09:25:12 	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68)
09:25:12 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
09:25:12 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
09:25:12 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
09:25:12 	at hudson.remoting.Engine$1$1.run(Engine.java:62)
09:25:12 	at java.lang.Thread.run(Thread.java:748)
09:25:12 Caused: java.io.IOException: Remote call on Channel to /159.203.77.233 failed
09:25:12 	at hudson.remoting.Channel.call(Channel.java:958)
09:25:12 	at hudson.FilePath.act(FilePath.java:998)
09:25:12 Caused: java.io.IOException: remote file operation failed: /home/iojs/build/workspace/node-test-commit-linux/nodes/ubuntu1604-32 at hudson.remoting.Channel@56f31e6f:Channel to /159.203.77.233
09:25:12 	at hudson.FilePath.act(FilePath.java:1005)
09:25:12 	at hudson.FilePath.act(FilePath.java:987)
09:25:12 	at org.jenkinsci.plugins.gitclient.Git.getClient(Git.java:137)
09:25:12 	at hudson.plugins.git.GitSCM.createClient(GitSCM.java:795)
09:25:12 	at hudson.plugins.git.GitSCM.createClient(GitSCM.java:786)
09:25:12 	at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1154)
09:25:12 	at hudson.scm.SCM.checkout(SCM.java:504)
09:25:12 	at hudson.model.AbstractProject.checkout(AbstractProject.java:1203)
09:25:12 	at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
09:25:12 	at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
09:25:12 	at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
09:25:12 	at hudson.model.Run.execute(Run.java:1727)
09:25:12 	at hudson.matrix.MatrixRun.run(MatrixRun.java:146)
09:25:12 	at hudson.model.ResourceController.execute(ResourceController.java:97)
09:25:12 	at hudson.model.Executor.run(Executor.java:429)
09:25:12 Run condition [Always] enabling perform for step [[]]
09:25:12 Run condition [Always] enabling perform for step [[]]
09:25:12 TAP Reports Processing: START
09:25:12 Looking for TAP results report in workspace using pattern: *.tap
09:25:12 Did not find any matching files. Setting build result to FAILURE.
09:25:12 Checking ^not ok
09:25:13 Jenkins Text Finder: File set '*.tap' is empty
09:25:13 Notifying upstream projects of job completion
09:25:13 Finished: FAILURE

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Apr 12, 2018
@danbev @BridgeAR
src: add node_internal.h includes for arraysize
0e81117 
This commit adds includes for node_internal.h in source files that use
arraysize but don't include this header. The motivation for this is to
make refactoring easier (and is the reason I noticed this).

PR-URL: nodejs#19916
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@BridgeAR
Copy link
Member

BridgeAR commented Apr 12, 2018

Landed in 0e81117 🎉

@BridgeAR BridgeAR closed this Apr 12, 2018
jasnell pushed a commit that referenced this pull request Apr 16, 2018
@danbev @jasnell
src: add node_internal.h includes for arraysize
17deb5f 
This commit adds includes for node_internal.h in source files that use
arraysize but don't include this header. The motivation for this is to
make refactoring easier (and is the reason I noticed this).

PR-URL: #19916
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request May 1, 2018
@danbev @BridgeAR
src: add node_internal.h includes for arraysize
8cdf541 
This commit adds includes for node_internal.h in source files that use
arraysize but don't include this header. The motivation for this is to
make refactoring easier (and is the reason I noticed this).

PR-URL: nodejs#19916
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@danbev danbev deleted the arraysize-includes branch July 2, 2018 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

+1 more reviewer

@gibfahn gibfahn gibfahn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land. lib / src Issues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@danbev @BridgeAR @jasnell @cjihrig @gibfahn @nodejs-github-bot