doc: remove superfluous word from crypto doc #19946
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
crypto
BridgeAR
approved these changes
Apr 11, 2018
Member
|
Lite-CI https://ci.nodejs.org/job/node-test-pull-request-lite/485/ @tniessen please be so kind and always trigger a CI when opening a new PR :-) |
Member
Author
|
Sorry and thank you for doing so @BridgeAR :) |
apapirovski
approved these changes
Apr 11, 2018
BridgeAR
added
the
author ready
cjihrig
approved these changes
Apr 11, 2018
jasnell
approved these changes
Apr 11, 2018
Member
Author
|
CI was aborted, retrying: https://ci.nodejs.org/job/node-test-pull-request-lite/487/ |
vsemozhetbyt
approved these changes
Apr 11, 2018
Contributor
|
There is one more such fragment in |
Member
Author
|
Thank you, @vsemozhetbyt! |
Member
Author
trivikr
approved these changes
Apr 12, 2018
Member
|
Landed in 0aab8ff |
trivikr
pushed a commit
that referenced
this pull request
Apr 12, 2018
PR-URL: #19946 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Apr 16, 2018
PR-URL: #19946 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
May 1, 2018
PR-URL: nodejs#19946 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
tniessen
removed
author ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should probably have been "If the
outputEncodingparameter is...", but "IfoutputEncodingis..." works as well.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes