doc: move evanlucas to TSC Emeritus #19953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
approved these changes
Apr 11, 2018
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
LGTM. Will miss your presence on the TSC, but thanks for setting a good example and stepping away when it makes sense. Thanks for all you've done and see you around!
Member
Member
|
@nodejs/tsc |
Trott
added
the
author ready
cjihrig
approved these changes
Apr 11, 2018
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
Thanks for everything Evan!
ofrobots
approved these changes
Apr 11, 2018
Contributor
ofrobots
left a comment
ofrobots
left a comment
There was a problem hiding this comment.
Thanks for everything @evanlucas!
Contributor
|
Thanks for all your contributions, @evanlucas ❤️ |
Fishrock123
approved these changes
Apr 11, 2018
Contributor
Fishrock123
left a comment
Fishrock123
left a comment
There was a problem hiding this comment.
Thanks for everything!
I no longer have the time to dedicate to being on the TSC. I am still planning to contribute when time permits. PR-URL: nodejs#19953 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Contributor
Author
|
Landed in 814d034 |
targos
pushed a commit
that referenced
this pull request
Apr 12, 2018
I no longer have the time to dedicate to being on the TSC. I am still planning to contribute when time permits. PR-URL: #19953 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
jasnell
pushed a commit
that referenced
this pull request
Apr 16, 2018
I no longer have the time to dedicate to being on the TSC. I am still planning to contribute when time permits. PR-URL: #19953 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I no longer have the time to dedicate to being on the TSC.
I am still planning to contribute when time permits.
Thanks to everyone who works on node regularly. :]
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes