doc: move trevnorris to TSC Emeritus #19985
Closed
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
approved these changes
Apr 12, 2018
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
Thanks for everything Trevor!
jasnell
approved these changes
Apr 12, 2018
targos
approved these changes
Apr 12, 2018
BridgeAR
reviewed
Apr 12, 2018
Member
BridgeAR
left a comment
BridgeAR
left a comment
There was a problem hiding this comment.
Thanks a lot for all you did for Node.js!
README.md
Outdated
Member
There was a problem hiding this comment.
This is the wrong spot to be removed from.
Trott
approved these changes
Apr 12, 2018
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
Sorry to see you go. Glad you'll still be around! Thanks for everything!
Trott
requested changes
Apr 12, 2018
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
Whoops, Ruben correctly points out that the removal is from the wrong list....
Trott
reviewed
Apr 12, 2018
README.md
Outdated
Member
There was a problem hiding this comment.
Hmmm...also added in the wrong place. (Lists are all alphabetical by GitHub handle.) I'll fix both of these things in a moment, assuming I have push access on the branch...
I'll still be around, but won't be able to contribute enough to merit TSC status.
Trott
force-pushed
the
trevnorris-emeritus
branch
from
68d3143 to
5341b83
Compare
Member
Trott
added
the
author ready
richardlau
approved these changes
Apr 12, 2018
BridgeAR
approved these changes
Apr 12, 2018
joyeecheung
approved these changes
Apr 12, 2018
Member
|
Re-running lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/508/ |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Apr 12, 2018
I'll still be around, but won't be able to contribute enough to merit TSC status. PR-URL: nodejs#19985 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Member
|
Landed in 636bac7 |
Member
|
Thanks again @trevnorris! |
Contributor
|
Thanks for all the hard work! |
jasnell
pushed a commit
that referenced
this pull request
Apr 16, 2018
I'll still be around, but won't be able to contribute enough to merit TSC status. PR-URL: #19985 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
May 1, 2018
I'll still be around, but won't be able to contribute enough to merit TSC status. PR-URL: nodejs#19985 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll still be around, but won't be able to contribute enough to merit
TSC status.
Checklist