src: use v8:: namepace consistently in node_file #20059
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently node_file.cc has a number of using declarations but in a few places still uses the qualified names. This commit changes this for consistency.
nodejs-github-bot
added
c++
Contributor
Author
Member
|
sidenote: i wonder if our linter script can be patched to catch stuff like this |
tniessen
approved these changes
Apr 16, 2018
addaleax
approved these changes
Apr 16, 2018
cjihrig
approved these changes
Apr 16, 2018
BridgeAR
added
the
author ready
jasnell
approved these changes
Apr 16, 2018
Contributor
Author
|
Landed in 8384b07. |
danbev
added a commit
that referenced
this pull request
Apr 18, 2018
Currently node_file.cc has a number of using declarations but in a few places still uses the qualified names. This commit changes this for consistency. PR-URL: #20059 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Apr 19, 2018
Currently node_file.cc has a number of using declarations but in a few places still uses the qualified names. This commit changes this for consistency. PR-URL: #20059 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently node_file.cc has a number of using declarations but in a few
places still uses the qualified names. This commit changes this for
consistency.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes