doc: fix inconsistency in documentation for building #20091
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, fix the inconsistency where the documentation suggests running "$ make test" instead of "$ make -j4 test". The "-j4" flag uses multiple processes, making the command faster. Fixes: #19919
nodejs-github-bot
added
build
Contributor
aks-
approved these changes
Apr 17, 2018
danbev
approved these changes
Apr 17, 2018
Trott
added
fast-track
jasnell
approved these changes
Apr 17, 2018
BridgeAR
approved these changes
Apr 18, 2018
trivikr
approved these changes
Apr 18, 2018
Contributor
Author
|
Is there a reason this hasn't landed yet? It's been three days and it has several approvals, and I thought those were the rules in pull-requests.md? Thanks! |
trivikr
pushed a commit
that referenced
this pull request
Apr 20, 2018
Specifically, fix the inconsistency where the documentation suggests running "$ make test" instead of "$ make -j4 test". The "-j4" flag uses multiple processes, making the command faster. Fixes: #19919 PR-URL: #20091 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Member
|
Landed in a456775 Congratulations @spwg on your first commit in Node.js core! 🎉🎉🎉 |
jasnell
pushed a commit
that referenced
this pull request
Apr 20, 2018
Specifically, fix the inconsistency where the documentation suggests running "$ make test" instead of "$ make -j4 test". The "-j4" flag uses multiple processes, making the command faster. Fixes: #19919 PR-URL: #20091 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, fix the inconsistency where the documentation
suggests running "$ make test" instead of "$ make -j4 test".
The "-j4" flag uses multiple processes, making the command
faster.
Fixes: #19919
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes