lib: remove duplicate require calls in tls.js #20099
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
lpinca
approved these changes
Apr 17, 2018
jasnell
approved these changes
Apr 17, 2018
richardlau
approved these changes
Apr 17, 2018
tniessen
approved these changes
Apr 17, 2018
BridgeAR
added
the
author ready
BridgeAR
approved these changes
Apr 18, 2018
XadillaX
approved these changes
Apr 18, 2018
trivikr
approved these changes
Apr 18, 2018
This commit removes the duplicate require calls of the _tls_common and _tls_wrap modules. The motivation for this being that even though the modules are cached the additional calls are unnecessary.
Contributor
Author
Contributor
Author
node-test-commit-aix failure looks unrelatednot ok 2136 sequential/test-benchmark-http
---
duration_ms: 120.141
severity: fail
exitcode: -15
stack: |-
timeout
...node-test-commit-osx failure looks unrelatedps awwx | grep Release/node | grep -v grep | cat
8467 ?? R 215:20.06 /Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1010/out/Release/node /Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1010/test/parallel/test-child-process-bad-stdio.js child
make[1]: *** [test-ci] Error 1
make: *** [run-ci] Error 2
Build step 'Execute shell' marked build as failure
Run condition [Always] enabling perform for step [[]]
TAP Reports Processing: START
Looking for TAP results report in workspace using pattern: *.t |
Contributor
Author
|
Landed in bbdb4af. |
danbev
added a commit
to danbev/node
that referenced
this pull request
Apr 19, 2018
This commit removes the duplicate require calls of the _tls_common and _tls_wrap modules. The motivation for this being that even though the modules are cached the additional calls are unnecessary. PR-URL: nodejs#20099 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Apr 19, 2018
This commit removes the duplicate require calls of the _tls_common and _tls_wrap modules. The motivation for this being that even though the modules are cached the additional calls are unnecessary. PR-URL: #20099 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the duplicate require calls of the
_tls_commonand_tls_wrapmodules. The motivation for this being that even though themodules are cached the additional calls are unnecessary.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes